linux-kernel - Re: d451564 breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091113224820.GB29657@elte.hu>
Date:	Fri, 13 Nov 2009 23:48:20 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Russell King <rmk@....linux.org.uk>
Cc:	Soeren Sandmann Pedersen <sandmann@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel List <linux-kernel@...r.kernel.org>
Subject: Re: d451564 breakage


* Russell King <rmk@....linux.org.uk> wrote:

> Change:
> 
> highmem: Fix debug_kmap_atomic() to also handle KM_IRQ_PTE, KM_NMI, and KM_NMI_PTE
> 
> Appears to break ARM:
> 
> mm/highmem.c: In function ???debug_kmap_atomic???:
> mm/highmem.c:436: error: ???KM_NMI??? undeclared (first use in this function)

indeed - sorry.

Note that debug_kmap_atomic() will be removed in v2.6.33 so i'd suggest 
to just do the easy solution and add #ifndef dummy definitions to 
mm/highmem.c to cover ARM - we'll remove the whole cruft for good.

Btw., testing sidenote: i test the ARM defconfig and it didnt break 
there. Perhaps highmem is off in the ARM defconfig? It would be helpful 
if the ARM defconfig enabled highmem.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/