linux-kernel - Re: [PATCH -tip 1/3] Pass mm->flags to binfmt core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091113232457.GC21666@elte.hu>
Date:	Sat, 14 Nov 2009 00:24:57 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Masami Hiramatsu <mhiramat@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>,
	systemtap <systemtap@...rces.redhat.com>,
	DLE <dle-develop@...ts.sourceforge.net>,
	Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Roland McGrath <roland@...hat.com>
Subject: Re: [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag
 consistency


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Fri, 13 Nov 2009 17:52:27 -0500
> Masami Hiramatsu <mhiramat@...hat.com> wrote:
> 
> > Pass mm->flags to binfmt core_dump for bitflag consistency.
> > Since mm->flags bit flags is not protected by locks, it will be
> > changed while dumping core. This patch copies mm->flags to a
> > mm_flags local variable at the beginning of do_coredump() and
> > use it while dumping. mm_flags also includes dump_filter which
> > filters elf sections from core file in elf_core_dump().
> > So, this patch also passes mm_flags to each binfmt->core_dump().
> 
> I can kind-of guess the answer, but it would be much more reliable if
> we were to hear this from yourself:
> 
>   Why did you write this patch?  What problem is being observed?

i'm not Masami so i'm only guessing that while writing the tracepoint a 
race got noticed but that otherwise there's no big practical effect, 
'just' a cleanliness problem fixed.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/