linux-kernel - Re: [PATCH] hpfs: Use hweight32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091113153255.9726be89.akpm@linux-foundation.org>
Date:	Fri, 13 Nov 2009 15:32:55 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] hpfs: Use hweight32

On Fri, 13 Nov 2009 16:07:08 +0900
Akinobu Mita <akinobu.mita@...il.com> wrote:

> Use hweight32 instead of counting for each bit
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> Cc: Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>
> Cc: Al Viro <viro@...iv.linux.org.uk>
> ---
>  fs/hpfs/super.c |    7 ++-----
>  1 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
> index f2feaa0..cf6fe4a 100644
> --- a/fs/hpfs/super.c
> +++ b/fs/hpfs/super.c
> @@ -119,11 +119,8 @@ unsigned hpfs_count_one_bitmap(struct super_block *s, secno secno)
>  	unsigned i, count;
>  	if (!(bits = hpfs_map_4sectors(s, secno, &qbh, 4))) return 0;
>  	count = 0;
> -	for (i = 0; i < 2048 / sizeof(unsigned); i++) {
> -		unsigned b; 
> -		if (!bits[i]) continue;
> -		for (b = bits[i]; b; b>>=1) count += b & 1;
> -	}
> +	for (i = 0; i < 2048 / sizeof(unsigned); i++)
> +		count += hweight32(bits[i]);
>  	hpfs_brelse4(&qbh);
>  	return count;

Could actualy use bitmap_weight() here.

It's a bit naughty, because bitmap_weight() operates on long*'s, but it
will work OK.

Shrug.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/