linux-kernel - Re: [PATCH] drivers/thermal/thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1258155450.16857.129.camel@Joe-Laptop.home>
Date:	Fri, 13 Nov 2009 15:37:30 -0800
From:	Joe Perches <joe@...ches.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Zhang Rui <rui.zhang@...el.com>,
	Sujith Thomas <sujith.thomas@...el.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/thermal/thermal_sys.c: fix strncmp tests

On Fri, 2009-11-13 at 14:22 -0800, Andrew Morton wrote:
> On Mon, 09 Nov 2009 14:12:49 -0800
> Joe Perches <joe@...ches.com> wrote:
> 
> > Use strncmp(var, "foo", sizeof("foo") - 1)
> > not strncmp(var, "foo", sizeof("foo"))
> > 
> > Signed-off-by: Joe Perches <joe@...ches.com>
> > 
> > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> > index 4e83c29..c35d538 100644
> > --- a/drivers/thermal/thermal_sys.c
> > +++ b/drivers/thermal/thermal_sys.c
> > @@ -147,9 +147,9 @@ mode_store(struct device *dev, struct device_attribute *attr,
> >  	if (!tz->ops->set_mode)
> >  		return -EPERM;
> >  
> > -	if (!strncmp(buf, "enabled", sizeof("enabled")))
> > +	if (!strncmp(buf, "enabled", sizeof("enabled") - 1))
> 
> How about
> 
> 	if (!strcmp(buf, "enabled"))

Fine with me.

I think strncmp(foo, "bar", sizeof("bar"))
where foo has a trailing 0 should be
converted to strcmp(foo, "bar");



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/