linux-kernel - Re: [PATCH] pxa: make index mfp unsigned in mfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f17812d70911122303x53892464le04883069ad99e64@mail.gmail.com>
Date:	Fri, 13 Nov 2009 15:03:35 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pxa: make index mfp unsigned in mfp_read() and write()

On Thu, Nov 12, 2009 at 12:05 AM, Roel Kluin <roel.kluin@...il.com> wrote:
> When signed, it is possible in theory to pass a negative mfp,
> and read/write outside the array bounds.
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
>  arch/arm/plat-pxa/include/plat/mfp.h |    4 ++--
>  arch/arm/plat-pxa/mfp.c              |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> I did not observe the passing of a negative mfp anywhere so this
> can be considered as a cleanup. Alternatively I could introduce
> a `mfp < 0' check in mfp_{read,write} instead if desired.
>

I'd prefer to have a check in mfp_{read,write} instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/