linux-kernel - Re: [PATCH] netfilter: nf_log: fix sleeping function called from invalid context in seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4AFD1A58.6090201@trash.net>
Date:	Fri, 13 Nov 2009 09:35:36 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Wu Fengguang <fengguang.wu@...el.com>
CC:	LKML <linux-kernel@...r.kernel.org>,
	"Yin, Kangkai" <kangkai.yin@...el.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] netfilter: nf_log: fix sleeping function called from
 invalid context in seq_show()

Wu Fengguang wrote:
> [  171.925285] BUG: sleeping function called from invalid context at kernel/mutex.c:280
> [  171.925296] in_atomic(): 1, irqs_disabled(): 0, pid: 671, name: grep
> [  171.925306] 2 locks held by grep/671:
> [  171.925312]  #0:  (&p->lock){+.+.+.}, at: [<c10b8acd>] seq_read+0x25/0x36c
> [  171.925340]  #1:  (rcu_read_lock){.+.+..}, at: [<c1391dac>] seq_start+0x0/0x44
> [  171.925372] Pid: 671, comm: grep Not tainted 2.6.31.6-4-netbook #3
> [  171.925380] Call Trace:
> [  171.925398]  [<c105104e>] ? __debug_show_held_locks+0x1e/0x20
> [  171.925414]  [<c10264ac>] __might_sleep+0xfb/0x102
> [  171.925430]  [<c1461521>] mutex_lock_nested+0x1c/0x2ad
> [  171.925444]  [<c1391c9e>] seq_show+0x74/0x127
> [  171.925456]  [<c10b8c5c>] seq_read+0x1b4/0x36c
> [  171.925469]  [<c10b8aa8>] ? seq_read+0x0/0x36c
> [  171.925483]  [<c10d5c8e>] proc_reg_read+0x60/0x74
> [  171.925496]  [<c10d5c2e>] ? proc_reg_read+0x0/0x74
> [  171.925510]  [<c10a4468>] vfs_read+0x87/0x110
> [  171.925523]  [<c10a458a>] sys_read+0x3b/0x60
> [  171.925538]  [<c1002a49>] syscall_call+0x7/0xb
> 
> Fix it by replacing RCU with nf_log_mutex.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/