linux-kernel - Re: [PATCH 2.6.32] ftrace: fix event format export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1258190498.6167.31.camel@johannes.local>
Date:	Sat, 14 Nov 2009 10:21:38 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	rostedt@...dmis.org
Cc:	Ingo Molnar <mingo@...e.hu>,
	Fr??d??ric Weisbecker <fweisbec@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2.6.32] ftrace: fix event format export

On Fri, 2009-11-13 at 18:28 -0500, Steven Rostedt wrote:

> > > Use
> > > 	"\"%s\"", fmt
> > > instead of
> > > 	"%s", #fmt
> > > to export the string and not the way it is built.
> 
> Is there any examples of this currently in the kernel? If so could you
> show that in the changlog.

net/mac80211/driver-trace.h has some that are exported really badly and
both trace-cmd and perf fall over on them.

Incidentally, the kvm_mmu ones are also weird, but I'm not sure they can
be fixed up properly.

Do you think Andreas's objection to the now-missing escaping of " and \
is a problem, or should we either fix the parsers to parse the string
backward from REC stuff, or fix the routine that outputs them to
userspace to quote " and \?

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)