linux-kernel - Re: [patch 0/1] Adding radio type FM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Nov 2009 19:05:09 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Janakiram Sistla <janakiram.sistla@...il.com>
Cc:	linux-wireless <linux-wireless@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 0/1] Adding radio type FM

Hi Janakiram,

> I thought i would see the change first in include/linux/rfkill.h
> getting accepted and then i can add the change in core.c also.
> 
> Let me know if i can push both in the same patch.

I said that you can add RFKILL_TYPE_FM to the RFKILL subsystem, but the
input changes might not be the right ones. Since eventually the
in-kernel input support will be removed.

And I did ask if the FM button you see is a generic RFKILL toggle or a
FM specific button. Especially since you had a copy-and-paste mistake in
your patches, that code path clearly was never tested by you.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/