linux-kernel - [tip:x86/debug] x86: Remove CPU cache size output for non-Intel too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-b01c845f0f2e3f9e54e6a78d5d56895f5b95e818@git.kernel.org>
Date:	Sat, 14 Nov 2009 00:54:37 GMT
From:	tip-bot for Roland Dreier <rdreier@...co.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	mingo@...hat.com, rusty@...tcorp.com.au, fweisbec@...il.com,
	rostedt@...dmis.org, gregkh@...e.de, ak@...ux.intel.com,
	heiko.carstens@...ibm.com, tglx@...utronix.de, rientjes@...gle.com,
	linux-kernel@...r.kernel.org, hpa@...or.com, yinghai@...nel.org,
	seto.hidetoshi@...fujitsu.com, travis@....com, davej@...hat.com,
	rdunlap@...otime.net, steiner@....com, rdreier@...co.com,
	tj@...nel.org, rolandd@...co.com, mingo@...e.hu
Subject: [tip:x86/debug] x86: Remove CPU cache size output for non-Intel too

Commit-ID:  b01c845f0f2e3f9e54e6a78d5d56895f5b95e818
Gitweb:     http://git.kernel.org/tip/b01c845f0f2e3f9e54e6a78d5d56895f5b95e818
Author:     Roland Dreier <rdreier@...co.com>
AuthorDate: Fri, 13 Nov 2009 14:38:26 -0800
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Sat, 14 Nov 2009 01:51:18 +0100

x86: Remove CPU cache size output for non-Intel too

As Dave Jones said about the output in intel_cacheinfo.c: "They
aren't useful, and pollute the dmesg output a lot (especially on
machines with many cores).  Also the same information can be
trivially found out from userspace."

Give the generic display_cacheinfo() function the same treatment.

Signed-off-by: Roland Dreier <rolandd@...co.com>
Acked-by: Dave Jones <davej@...hat.com>
Cc: Mike Travis <travis@....com>
Cc: Andi Kleen <ak@...ux.intel.com>
Cc: Heiko Carstens <heiko.carstens@...ibm.com>
Cc: Randy Dunlap <rdunlap@...otime.net>
Cc: Tejun Heo <tj@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...e.de>
Cc: Yinghai Lu <yinghai@...nel.org>
Cc: David Rientjes <rientjes@...gle.com>
Cc: Steven Rostedt <rostedt@...dmis.org>
Cc: Rusty Russell <rusty@...tcorp.com.au>
Cc: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Cc: Jack Steiner <steiner@....com>
Cc: Frederic Weisbecker <fweisbec@...il.com>
LKML-Reference: <adaocn6dp99.fsf_-_@...and-alpha.cisco.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/kernel/cpu/common.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 617a29f..9db1e24 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -391,8 +391,6 @@ void __cpuinit display_cacheinfo(struct cpuinfo_x86 *c)
 
 	if (n >= 0x80000005) {
 		cpuid(0x80000005, &dummy, &ebx, &ecx, &edx);
-		printk(KERN_INFO "CPU: L1 I Cache: %dK (%d bytes/line), D cache %dK (%d bytes/line)\n",
-				edx>>24, edx&0xFF, ecx>>24, ecx&0xFF);
 		c->x86_cache_size = (ecx>>24) + (edx>>24);
 #ifdef CONFIG_X86_64
 		/* On K8 L1 TLB is inclusive, so don't count it */
@@ -422,9 +420,6 @@ void __cpuinit display_cacheinfo(struct cpuinfo_x86 *c)
 #endif
 
 	c->x86_cache_size = l2size;
-
-	printk(KERN_INFO "CPU: L2 Cache: %dK (%d bytes/line)\n",
-			l2size, ecx & 0xFF);
 }
 
 void __cpuinit detect_ht(struct cpuinfo_x86 *c)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/