linux-kernel - Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to &proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091115065958.GA2459@hack>
Date:	Sun, 15 Nov 2009 14:59:58 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to
	&proc_dointvec,

On Sat, Nov 14, 2009 at 05:52:05PM -0800, Joe Perches wrote:
>Seems to be a typo.
>

Well, in this case, proc_dointvec == &proc_dointvec,
both of them are the same function pointer.

But yes, &proc_dointvec looks more readable.

>Signed-off-by: Joe Perches <joe@...ches.com>

Acked-by: WANG Cong <xiyou.wangcong@...il.com>

>
>diff --git a/kernel/sysctl.c b/kernel/sysctl.c
>index 0d949c5..d0bf4eb 100644
>--- a/kernel/sysctl.c
>+++ b/kernel/sysctl.c
>@@ -1605,7 +1605,7 @@ static struct ctl_table debug_table[] = {
> 		.data		= &show_unhandled_signals,
> 		.maxlen		= sizeof(int),
> 		.mode		= 0644,
>-		.proc_handler	= proc_dointvec
>+		.proc_handler	= &proc_dointvec,
> 	},
> #endif
> 	{ .ctl_name = 0 }
>
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Live like a child, think like the god.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/