linux-kernel - Re: [PATCH 1/2] mfd: pcf50633 - fix error handling during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B008A22.80909@metafoo.de>
Date:	Mon, 16 Nov 2009 00:09:22 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mfd: pcf50633 - fix error handling during probe

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dmitry Torokhov wrote:
> The pcf50633 is very naive - it assumes that all driver core
> operations will succeed and will fail badly if one of them
> errors out. Implement proper error handling and make sure we
> release any and all resources that have been allocated prior
> to failure.
>
> Also avoid memory leak when using platform_device_add_data()
> which clones the supplied data structure for use by the device.
> The original copy, if allocated dynamically, needs to be freed
> by the caller; switch to using on-stack variable (the size of
> the structure in question is quite small) instead.
>
> Signed-off-by: Dmitry Torokhov <dtor@...l.ru>
Hi

Most of the issues addressed in this patch have already been fixed.
Please check the for-next branch in the mfd tree.

- - Lars
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksAiiIACgkQBX4mSR26RiNJbACfYs4UhLSrlYuNqynJ/Mguw+oj
FxQAn2xmUh8QZttY4jxKUsdg+6p/pXNT
=yCtL
-----END PGP SIGNATURE-----

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/