linux-kernel - Re: [PATCH] checkpatch: fix false positive on _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091116140220.GC30609@pengutronix.de>
Date:	Mon, 16 Nov 2009 15:02:35 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	linux-kernel@...r.kernel.org
Cc:	Andy Whitcroft <apw@...dowen.org>
Subject: Re: [PATCH] checkpatch: fix false positive on __initconst

ping

On Mon, Oct 19, 2009 at 11:49:14AM +0200, Wolfram Sang wrote:
> checkpatch falsely complained about '__initconst' because it thought the
> 'const' needed a space before. Fix this by changing the list of attributes:
> 
> - add '__initconst'
> - force plain 'init' to contain a word-boundary at the end
> 
> Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
> Cc: Andy Whitcroft <apw@...dowen.org>
> ---
> 
> Not entirely sure if adding the word boundary may cause a side-effect which I
> overlooked. A few more eyes on this would be great.
> 
>  scripts/checkpatch.pl |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 87bbb8b..0a47a1f 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -142,11 +142,14 @@ our $Sparse	= qr{
>  			__kprobes|
>  			__ref
>  		}x;
> +
> +# Notes to $Attribute:
> +# We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
>  our $Attribute	= qr{
>  			const|
>  			__read_mostly|
>  			__kprobes|
> -			__(?:mem|cpu|dev|)(?:initdata|init)|
> +			__(?:mem|cpu|dev|)(?:initdata|initconst|init\b)|
>  			____cacheline_aligned|
>  			____cacheline_aligned_in_smp|
>  			____cacheline_internodealigned_in_smp|
> -- 
> 1.6.3.3
> 

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)