linux-kernel - Re: [PATCH v5 12/12] tree-wide: convert open calls to remove spaces to skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091116150224.GA22176@khazad-dum.debian.net>
Date:	Mon, 16 Nov 2009 13:02:24 -0200
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	André Goddard Rosa <andre.goddard@...il.com>
Cc:	linux list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Julia Lawall <julia@...u.dk>
Subject: Re: [PATCH v5 12/12] tree-wide: convert open calls to remove
	spaces to skip_spaces() lib function

> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index d93108d..e8026d9 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -1006,11 +1006,8 @@ static int parse_strtoul(const char *buf,
>  {
>  	char *endp;
>  
> -	while (*buf && isspace(*buf))
> -		buf++;
> -	*value = simple_strtoul(buf, &endp, 0);
> -	while (*endp && isspace(*endp))
> -		endp++;
> +	*value = simple_strtoul(skip_spaces(buf), &endp, 0);
> +	endp = skip_spaces(endp);
>  	if (*endp || *value > max)
>  		return -EINVAL;
>  

Acked-by: Henrique de Moraes Holschuh <hmh@....eng.br>
(thinkpad-acpi changes only)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/