linux-kernel - Re: [PATCH] x86: Add missing might_fault() from copy_{to,from}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091116150937.GA22187@elte.hu>
Date:	Mon, 16 Nov 2009 16:09:37 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [PATCH] x86: Add missing might_fault() from copy_{to,from}_user()


* Frederic Weisbecker <fweisbec@...il.com> wrote:

> In x86-64, copy_to/from_user() rely on assembly routines that never
> call might_fault(), making us missing various lockdep checks.
> 
> This doesn't apply to __copy_from,to_user() that explicitly handle
> these calls, neither is it a problem in x86-32 where
> copy_to,from_user() rely on the "__" prefixed versions that also call
> might_fault().
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> ---
>  arch/x86/include/asm/uaccess_64.h |   10 +++++++++-
>  arch/x86/lib/copy_user_64.S       |    4 ++--
>  2 files changed, 11 insertions(+), 3 deletions(-)

Looks good - other than that you missed the renaming of the symbol 
export line in arch/x86/kernel/x8664_ksyms_64.c, which i fixed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/