[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091116153000.GB29479@sirena.org.uk>
Date: Mon, 16 Nov 2009 15:30:00 +0000
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
To: Kuninori Morimoto <morimoto.kuninori@...esas.com>
Cc: alsa-devel@...a-project.org, linux-pm@...ts.linux-foundation.org,
Magnus Damm <damm@...nsource.se>, linux-kernel@...r.kernel.org
Subject: Null suspend/resume functions
On Mon, Nov 09, 2009 at 01:31:36PM +0000, Mark Brown wrote:
> On Mon, Nov 09, 2009 at 10:58:58AM +0000, Mark Brown wrote:
> > On Mon, Nov 09, 2009 at 11:54:47AM +0900, Kuninori Morimoto wrote:
Any chance someone from the PM side could comment on the issue below?
> > > +static int fsi_runtime_nop(struct device *dev)
> > > +{
> > > + /* Runtime PM callback shared between ->runtime_suspend()
> > > + * and ->runtime_resume(). Simply returns success.
> > > + *
> > > + * This driver re-initializes all registers after
> > > + * pm_runtime_get_sync() anyway so there is no need
> > > + * to save and restore registers here.
> > > + */
> > > + return 0;
> > > +}
> >
> > This sets off alarm bells but it's perfectly reasonable, especially with
> > platforms able to put things into a low power state with no explicit
> > driver code now they can do power domain style things like SH. I've
> > CCed in the PM folks since this seems like a perfectly reasonable use
> > case which ought to be handled more nicely.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists