linux-kernel - Re: [PATCH] microblaze: Fix pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091116141426.9fc63622.akpm@linux-foundation.org>
Date:	Mon, 16 Nov 2009 14:14:26 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	steve@...idescorp.com
Cc:	microblaze-uclinux@...e.uq.edu.au, monstr@...str.eu,
	linux-kernel@...r.kernel.org,
	Chen Liqin <liqin.chen@...plusct.com>,
	Lennox Wu <lennox.wu@...il.com>,
	David Howells <dhowells@...hat.com>,
	Greg Ungerer <gerg@...pgear.com>
Subject: Re: [PATCH] microblaze: Fix pfn_valid() for noMMU

On Fri, 13 Nov 2009 16:08:29 -0600
steve@...idescorp.com wrote:

> Configuring DEBUG_SLAB causes a noMMU kernel to die during initialization
> with an invalid virtual address panic in kfree_debugcheck().
> The panic is due to an improper definition of pfn_valid().
> 
> Signed-off-by: Steven J. Magnani <steve@...idescorp.com>
> ---
> diff -uprN a/arch/microblaze/include/asm/page.h b/arch/microblaze/include/asm/page.h
> --- a/arch/microblaze/include/asm/page.h	2009-09-09 17:13:59.000000000 -0500
> +++ b/arch/microblaze/include/asm/page.h	2009-11-13 15:20:26.000000000 -0600
> @@ -161,7 +161,8 @@ extern int page_is_ram(unsigned long pfn
>  #  endif /* CONFIG_MMU */
>  
>  #  ifndef CONFIG_MMU
> -#  define pfn_valid(pfn)	((pfn) >= min_low_pfn && (pfn) <= max_mapnr)
> +#  define pfn_valid(pfn)	(((pfn) >= min_low_pfn) && \
> +				((pfn) <= (min_low_pfn + max_mapnr)))
>  #  define ARCH_PFN_OFFSET	(PAGE_OFFSET >> PAGE_SHIFT)
>  #  else /* CONFIG_MMU */
>  #  define ARCH_PFN_OFFSET	(memory_start >> PAGE_SHIFT)

Is arch/score/include/asm/page.h buggy also?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/