lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Nov 2009 20:19:25 +0900 (JST) From: Hitoshi Mitake <mitake@....info.waseda.ac.jp> To: mingo@...e.hu Cc: linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl, paulus@...ba.org, fweisbec@...il.com, ling.ma@...el.com Subject: Re: [PATCH 1/4] perf bench: Add new subsystem and new suite, bench/mem-memcpy.c From: Ingo Molnar <mingo@...e.hu> Subject: Re: [PATCH 1/4] perf bench: Add new subsystem and new suite, bench/mem-memcpy.c Date: Fri, 13 Nov 2009 10:46:50 +0100 I've fixed mem-memcpy.c according to your comment, but I also have some comments. > > > +}; > > + > > +struct routine routines[] = { > > + { "default", > > + memcpy, > > + "Default memcpy() provided by glibc" }, > > + { NULL, > > + NULL, > > + NULL } > > { NULL, } would be equivalent i guess. Initializing the termination with { NULL, } causes build error. So I can't change this point. > > + break; > > + case BENCH_FORMAT_SIMPLE: > > + if (use_clockcycle) > > + printf("%lf\n", > > + (double)clock_diff / (double)length); > > + else > > + printf("%lf\n", bps); > > + break; > > + default: > > + /* reaching here is something disaster */ > > + fprintf(stderr, "Unknown format:%d\n", bench_format); > > could use pr_err() here i guess. It seems that pr_err() is a wrapper for printk(), so I can't use pr_err() in perf. I'll send the patch later. Thanks for your comments! Hitoshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists