[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <tip-1124ba73be6a758965340bd997593b2996649d60@git.kernel.org>
Date: Tue, 17 Nov 2009 06:32:25 GMT
From: tip-bot for Arnaldo Carvalho de Melo <acme@...hat.com>
To: linux-tip-commits@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, paulus@...ba.org, acme@...hat.com,
hpa@...or.com, mingo@...hat.com, efault@....de,
peterz@...radead.org, fweisbec@...il.com, tglx@...utronix.de,
mingo@...e.hu
Subject: [tip:perf/core] perf buildid-list: Always show the DSO name
Commit-ID: 1124ba73be6a758965340bd997593b2996649d60
Gitweb: http://git.kernel.org/tip/1124ba73be6a758965340bd997593b2996649d60
Author: Arnaldo Carvalho de Melo <acme@...hat.com>
AuthorDate: Mon, 16 Nov 2009 21:45:25 -0200
Committer: Ingo Molnar <mingo@...e.hu>
CommitDate: Tue, 17 Nov 2009 07:19:54 +0100
perf buildid-list: Always show the DSO name
Porcelain can ignore it, humans can make more sense of it.
Suggested-by: Frederic Weisbecker <fweisbec@...il.com>
Suggested-by: Ingo Molnar <mingo@...e.hu>
Suggested-by: Peter Zijlstra <peterz@...radead.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
Cc: Frederic Weisbecker <fweisbec@...il.com>
Cc: Mike Galbraith <efault@....de>
Cc: Paul Mackerras <paulus@...ba.org>
Cc: Peter Zijlstra <peterz@...radead.org>
LKML-Reference: <1258415125-15019-2-git-send-email-acme@...radead.org>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
tools/perf/Documentation/perf-buildid-list.txt | 2 +-
tools/perf/builtin-buildid-list.c | 2 +-
tools/perf/util/symbol.c | 5 +----
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/tools/perf/Documentation/perf-buildid-list.txt b/tools/perf/Documentation/perf-buildid-list.txt
index abab34e..01b642c 100644
--- a/tools/perf/Documentation/perf-buildid-list.txt
+++ b/tools/perf/Documentation/perf-buildid-list.txt
@@ -26,7 +26,7 @@ OPTIONS
Don't do ownership validation.
-v::
--verbose::
- Be more verbose, showing the name of the DSOs after the buildids.
+ Be more verbose.
SEE ALSO
--------
diff --git a/tools/perf/builtin-buildid-list.c b/tools/perf/builtin-buildid-list.c
index 2e377e1..7dee9d1 100644
--- a/tools/perf/builtin-buildid-list.c
+++ b/tools/perf/builtin-buildid-list.c
@@ -28,7 +28,7 @@ static const struct option options[] = {
"input file name"),
OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
OPT_BOOLEAN('v', "verbose", &verbose,
- "be more verbose (show counter open errors, etc)"),
+ "be more verbose"),
OPT_END()
};
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 53de9c4..1b77e81 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1442,10 +1442,7 @@ size_t dsos__fprintf_buildid(FILE *fp)
list_for_each_entry(pos, &dsos, node) {
ret += dso__fprintf_buildid(pos, fp);
- if (verbose)
- ret += fprintf(fp, " %s\n", pos->long_name);
- else
- ret += fprintf(fp, "\n");
+ ret += fprintf(fp, " %s\n", pos->long_name);
}
return ret;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists