linux-kernel - Re: is avoiding compat ioctls possible?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Nov 2009 10:09:14 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Dave Airlie <airlied@...il.com>
Cc:	Arnd Bergmann <arnd@...db.de>, David Miller <davem@...emloft.net>,
	airlied@...ux.ie, dri-devel@...ts.sourceforge.net,
	andi@...stfloor.org, linux-kernel@...r.kernel.org
Subject: Re: is avoiding compat ioctls possible?

> Doing all these out-of-line hidden over here in a separate file just
> seems crazy,
> and I'm  having trouble wondering why ppl consider it a better idea at all.

The separate file is on the way out, the modern way is to use
->compat_ioctl in the driver itself. Near all drivers except
for a few exceptions like DRM put it into the same file.
I think you should just move the code  around in DRM too
and drop the separate file.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/