linux-kernel - Re: [PATCH 1/1] Add all TWL4030 regulators to Regulator framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091118143609.GD2832@esdhcp037198.research.nokia.com>
Date:	Wed, 18 Nov 2009 16:36:09 +0200
From:	Eduardo Valentin <eduardo.valentin@...ia.com>
To:	ext Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	"Keski-Saari Juha.1 (EXT-Teleca/Helsinki)" 
	<ext-juha.1.keski-saari@...ia.com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"dbrownell@...rs.sourceforge.net" <dbrownell@...rs.sourceforge.net>,
	"tony@...mide.com" <tony@...mide.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lrg@...mlogic.co.uk" <lrg@...mlogic.co.uk>,
	"Hunter Adrian (Nokia-D/Helsinki)" <adrian.hunter@...ia.com>,
	"amit.kucheria@...durent.com" <amit.kucheria@...durent.com>,
	"dtor@...l.ru" <dtor@...l.ru>,
	"Valentin Eduardo (Nokia-D/Helsinki)" <eduardo.valentin@...ia.com>,
	"De-Schrijver Peter (Nokia-D/Helsinki)" 
	<Peter.De-Schrijver@...ia.com>,
	"Kristo Tero (Nokia-D/Tampere)" <Tero.Kristo@...ia.com>
Subject: Re: [PATCH 1/1] Add all TWL4030 regulators to Regulator framework

On Wed, Nov 18, 2009 at 02:39:39PM +0100, Mark Brown wrote:
> On Wed, Nov 18, 2009 at 01:46:35PM +0200, Juha Keski-Saari wrote:
> > This patch adds all the remaining TWL4030 regulators into the implementation,
> > also adding VINT* regulators in this way since they can be derived out from
> > the TWL
> > 
> > Signed-off-by: Juha Keski-Saari <ext-juha.1.keski-saari@...ia.com>
> 
> This is fine from an API point of view but I worry that if any of the
> boards are using regulator_has_full_constraints() then this will break
> them by causing them to be powered off at the end of init.  Have you
> checked the in-tree twl4030 users for this?

Looks like no one is using the regulator_has_full_constraints(). At least the twl4030 users.

But maybe these VINT* should be set as always_on in twl4030-regulator driver?

-- 
Eduardo Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/