linux-kernel - Re: [PATCH 1/2] BKL: Remove BKL from default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091118181606.1c8caab1@lxorguk.ukuu.org.uk>
Date:	Wed, 18 Nov 2009 18:16:06 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jamie Lokier <jamie@...reable.org>
Cc:	Oliver Neukum <oliver@...kum.org>, Jan Blunck <jblunck@...e.de>,
	linux-fsdevel@...r.kernel.org,
	Linux-Kernel Mailinglist <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>, jkacur@...hat.com,
	Thomas Gleixner <tglx@...utronix.de>,
	Arnd Bergmann <arnd@...db.de>,
	Christoph Hellwig <hch@...radead.org>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH 1/2] BKL: Remove BKL from default_llseek()

O> But nowadays, even that doesn't happen.  sys_read() and sys_write()
> make a copy of f_pos using file_pos_read(), so drivers cannot see the
> value change during the call - except for their own change.
> 
> I find myself wondering why the VFS isn't responsible for the position
> update instead of the driver...  Would it be a valid cleanup to move
> it from the driver to VFS?

And how would you adjust it. Not all devices have a bytes read == offset
relationship. The VFS doesn't know enough.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/