linux-kernel - Re: [PATCH] selinux: Fix warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.0911190909030.22277@tundra.namei.org>
Date:	Thu, 19 Nov 2009 09:09:20 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Américo Wang <xiyou.wangcong@...il.com>
cc:	Alan Cox <alan@...ux.intel.com>, linux-kernel@...r.kernel.org,
	selinux@...ho.nsa.gov
Subject: Re: [PATCH] selinux: Fix warnings

On Thu, 19 Nov 2009, Am?rico Wang wrote:

> On Wed, Nov 18, 2009 at 02:39:51PM +0000, Alan Cox wrote:
> >scripts/selinux/genheaders/genheaders.c:20: warning: no previous prototype  
> >for ?usage?
> >scripts/selinux/genheaders/genheaders.c:26: warning: no previous prototype
> >for ?stoupperx?
> >
> >Signed-off-by: Alan Cox <alan@...ux.intel.com>
> 
> Acked-by: WANG Cong <xiyou.wangcong@...il.com>
> 

Thanks.


Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next

> >---
> >
> > scripts/selinux/genheaders/genheaders.c |    4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> >
> >diff --git a/scripts/selinux/genheaders/genheaders.c b/scripts/selinux/genheaders/genheaders.c
> >index 3b16145..771b86f 100644
> >--- a/scripts/selinux/genheaders/genheaders.c
> >+++ b/scripts/selinux/genheaders/genheaders.c
> >@@ -17,13 +17,13 @@ struct security_class_mapping {
> > 
> > const char *progname;
> > 
> >-void usage(void)
> >+static void usage(void)
> > {
> > 	printf("usage: %s flask.h av_permissions.h\n", progname);
> > 	exit(1);
> > }
> > 
> >-char *stoupperx(const char *s)
> >+static char *stoupperx(const char *s)
> > {
> > 	char *s2 = strdup(s);
> > 	char *p;
> >
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >the body of a message to majordomo@...r.kernel.org
> >More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >Please read the FAQ at  http://www.tux.org/lkml/
> 
> -- 
> Live like a child, think like the god.
>  
> 

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/