linux-kernel - Re: [PATCH 3/4] perf symbols: Record the build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091118223341.GC14014@ghostprotocols.net>
Date:	Wed, 18 Nov 2009 20:33:41 -0200
From:	Arnaldo Carvalho de Melo <acme@...radead.org>
To:	Roland McGrath <roland@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH 3/4] perf symbols: Record the build_ids of kernel
	modules too

Em Wed, Nov 18, 2009 at 02:29:10PM -0800, Roland McGrath escreveu:
> > +		snprintf(name, sizeof(name),
> > +			 "/sys/module/%s/notes/.note.gnu.build-id", line);
> 
> The arch linker script for .ko's is free to fold notes into a single
> section with a different name or suchlike, and maybe future ones will.  So
> it's not pedantically kosher to assume the name of the section rather than
> just looking at all the /sys/module/%s/notes/* files present until you find
> NT_GNU_BUILD_ID.  (In practice there is probably only ever one file there
> to look at, but you never know.)

Ahah! That seems to explain why the kernel one is "notes" while the
modules's are ".note.gnu.build-id"! I'll cook a super-dupa-careful
cooker follow on patch to get that right, thanks again!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/