linux-kernel - [PATCH] x86/pat: no need to check overlaps with more than one entry in chk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1258512455-1891-1-git-send-email-dfeng@redhat.com>
Date:	Wed, 18 Nov 2009 10:47:35 +0800
From:	Xiaotian Feng <dfeng@...hat.com>
To:	x86@...nel.org
Cc:	linux-kernel@...r.kernel.org, Xiaotian Feng <dfeng@...hat.com>,
	Ingo Molnar <mingo@...hat.com>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>
Subject: [PATCH] x86/pat: no need to check overlaps with more than one entry in chk_conflict

memtype list is built via reserve_memtype, for the overlapped areas, they're
all the same type, otherwise reserve_memtype will fail to insert it into the
list. So there's no need to check overlaps with more than one entry in the
chk_conflict code.

Signed-off-by: Xiaotian Feng <dfeng@...hat.com>
Cc: Ingo Molnar <mingo@...hat.com>
Cc: Suresh Siddha <suresh.b.siddha@...el.com>
Cc: Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>
---
 arch/x86/mm/pat.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
index 81fb753..8178763 100644
--- a/arch/x86/mm/pat.c
+++ b/arch/x86/mm/pat.c
@@ -247,13 +247,6 @@ chk_conflict(struct memtype *new, struct memtype *entry, unsigned long *type)
 			goto conflict;
 	}
 
-	 /* check overlaps with more than one entry in the list */
-	list_for_each_entry_continue(entry, &memtype_list, nd) {
-		if (new->end <= entry->start)
-			break;
-		else if (new->type != entry->type)
-			goto conflict;
-	}
 	return 0;
 
  conflict:
-- 
1.6.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/