linux-kernel - Re: [PATCH] ARM: Add spi controller driver support for NUC900

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091119090204.GB13376@n2100.arm.linux.org.uk>
Date:	Thu, 19 Nov 2009 09:02:04 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Wan ZongShun <mcuos.com@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-spi <spi-devel-general@...ts.sourceforge.net>,
	David Brownell-sourceforge <dbrownell@...rs.sourceforge.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: Add spi controller driver support for NUC900

On Thu, Nov 19, 2009 at 04:40:50PM +0800, Wan ZongShun wrote:
> 2009/11/19 Andrew Morton <akpm@...ux-foundation.org>:
> > I don't know, because I don't know what operation the hardware needs to
> > stop it from generating interrupts.  Perhaps that's clk_disable()?
> 
> The interrupt will be not occur as long as I run clk_disable().
> 
> > Once you've stopped the source of interrupts then the code should wait
> > for the IRQ handler to complete if it's running on another CPU.  Yes,
> > free_irq() does that.
> 
> So, regarding my system of single CPU, maybe I need put this
> 'clk_disable()' in the front of function of w90p910_spi_remove().
> 
> right?

Depending on the hardware, that's not the right answer.  If turning off
the clock also causes register accesses to the device to abort, it is
a very dangerous thing to do.

It can also be dangerous if the clock is used to synchronise the interrupt
output - it can lead to the output being permanently asserted if the clock
is turned off with it asserted.

Normally devices have an "interrupt enable" register.  You should disable
all interrupts from the device using this register after unregistering
the driver from the (SPI) subsystem.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/