[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1258744079.3640.435.camel@odin>
Date: Fri, 20 Nov 2009 19:07:59 +0000
From: Liam Girdwood <lrg@...mlogic.co.uk>
To: Eduardo Valentin <eduardo.valentin@...ia.com>
Cc: Mark Brown <broonie@...nsource.wolfsonmicro.com>,
David Brownell <dbrownell@...rs.sourceforge.net>,
Samuel Ortiz <sameo@...ux.intel.com>,
LKML <linux-kernel@...r.kernel.org>,
"\\\"De-Schrijver Peter (Nokia-D/Helsinki)\\\""
<Peter.De-Schrijver@...ia.com>
Subject: Re: [PATCH 1/1] twl4030-regulator: Remove regulator from all
groups when disabling
On Fri, 2009-11-20 at 18:29 +0200, Eduardo Valentin wrote:
> Just remove regulator from all groups when disabling. This way we
> avoid problems if boot loader touches twl4030 registers.
>
> Signed-off-by: Eduardo Valentin <eduardo.valentin@...ia.com>
> ---
> drivers/regulator/twl4030-regulator.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/twl4030-regulator.c b/drivers/regulator/twl4030-regulator.c
> index e2032fb..27b3115 100644
> --- a/drivers/regulator/twl4030-regulator.c
> +++ b/drivers/regulator/twl4030-regulator.c
> @@ -126,7 +126,7 @@ static int twl4030reg_disable(struct regulator_dev *rdev)
> if (grp < 0)
> return grp;
>
> - grp &= ~P1_GRP;
> + grp &= ~(P1_GRP & P2_GRP | P3_GRP);
> return twl4030reg_write(info, VREG_GRP, grp);
> }
>
Applied.
Thanks
Liam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists