| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <9929d2390911201116l562291cbh8e6a557b64fa7ef0@mail.gmail.com> Date: Fri, 20 Nov 2009 11:16:54 -0800 From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> To: David Miller <davem@...emloft.net> Cc: jaswinder@...nel.org, yi.zou@...el.com, peter.p.waskiewicz.jr@...el.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ixgbe: move tc variable to CONFIG_IXGBE_DCB On Fri, Nov 20, 2009 at 11:13, David Miller <davem@...emloft.net> wrote: > From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> > Date: Fri, 20 Nov 2009 06:24:21 -0800 > >> On Fri, Nov 20, 2009 at 06:02, Jaswinder Singh Rajput >> <jaswinder@...nel.org> wrote: >>> >>> tc is required by CONFIG_IXGBE_DCB. >>> This also fixes compilation warning: >>> >>> drivers/net/ixgbe/ixgbe_main.c: In function ‘ixgbe_tx_is_paused’: >>> drivers/net/ixgbe/ixgbe_main.c:245: warning: unused variable ‘tc’ >>> >>> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com> > ... >> I just submitted a patch to fix this. So NAK. > > But his is much cleaner that your's, less ifdefs. I think we > should therefore use Jasdinder's version. > > :) That is fine. The end result is the same. Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com> -- Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists