linux-kernel - Re: [PATCH] mm/nommu.c: Fix improperly call of security API in mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1258747132.2916.15.camel@dhcp231-106.rdu.redhat.com>
Date:	Fri, 20 Nov 2009 14:58:52 -0500
From:	Eric Paris <eparis@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	David Howells <dhowells@...hat.com>, graff.yang@...il.com,
	linux-kernel@...r.kernel.org, gyang@...ckfin.uclinux.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	Graff Yang <graf.yang@...log.com>,
	linux-security-module@...r.kernel.org, john.johansen@...onical.com
Subject: Re: [PATCH] mm/nommu.c: Fix improperly call of security API in mmap

On Fri, 2009-11-20 at 11:50 -0800, Andrew Morton wrote:
> On Fri, 20 Nov 2009 14:32:02 -0500

> >     security: do not check mmap_min_addr on nommu systems
> >     
> >     nommu systems can do anything with memory they please and so they already
> >     win.  mmap_min_addr is the least of their worries.  Currently the
> >     mmap_min_addr implementation is problamatic on such systems.  This patch
> >     changes the addr_only argument to be a flags which can take the arguments
> >     for addr_only or not_addr.  LSMs then need to properly implement these two
> >     flags.
> >     
> >     Signed-off-by: Eric Paris <eparis@...hat.com>
> 
> Patch doesn't apply to current mainline for some reason.  I fixed that
> up and checked that the affected files compile OK on superh.

It was against my linux-next devel tree, probably something new in
James' for-next tree.  Are people hoping for this in stable or should we
just queue for -next?  This is a pretty old bug I guess people are just
hitting for the first time...

> The patch adds trailing whitespace.  If only we had a tool for that ;)

Fixed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/