linux-kernel - Re: [PATCH] V4L/DVB: Fix test in copy_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B0739F5.4090403@linuxtv.org>
Date:	Fri, 20 Nov 2009 19:53:09 -0500
From:	Michael Krufky <mkrufky@...uxtv.org>
To:	Roel Kluin <roel.kluin@...il.com>
CC:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-media@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] V4L/DVB: Fix test in copy_reg_bits()

Ah!  Nice catch.  Thank you, Roel.  Mauro / Andrew, can one of you 
please merge this?  The driver hasn't changed, so it should go to Linus' 
current tree and also stable, although it isn't crucial.

Signed-off-by: Michael Krufky <mkrufky@...uxtv.org>

Roel Kluin wrote:
> The reg_pair2[j].reg was tested twice.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
>  drivers/media/common/tuners/mxl5007t.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> I think this was intended?
> 
> diff --git a/drivers/media/common/tuners/mxl5007t.c b/drivers/media/common/tuners/mxl5007t.c
> index 2d02698..7eb1bf7 100644
> --- a/drivers/media/common/tuners/mxl5007t.c
> +++ b/drivers/media/common/tuners/mxl5007t.c
> @@ -196,7 +196,7 @@ static void copy_reg_bits(struct reg_pair_t *reg_pair1,
>  	i = j = 0;
>  
>  	while (reg_pair1[i].reg || reg_pair1[i].val) {
> -		while (reg_pair2[j].reg || reg_pair2[j].reg) {
> +		while (reg_pair2[j].reg || reg_pair2[j].val) {
>  			if (reg_pair1[i].reg != reg_pair2[j].reg) {
>  				j++;
>  				continue;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/