linux-kernel - [PATCH 7/8] drivers/dma: introduce missing kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0911211252180.23681@ask.diku.dk>
Date:	Sat, 21 Nov 2009 12:52:44 +0100 (CET)
From:	Julia Lawall <julia@...u.dk>
To:	maciej.sosnowski@...el.com,
	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH 7/8] drivers/dma: introduce missing kfree

From: Julia Lawall <julia@...u.dk>

Error handling code following a kzalloc should free the allocated data.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@...u.dk>
---
 drivers/dma/shdma.c                 |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/shdma.c b/drivers/dma/shdma.c
index b3b065c..0cd0d58 100644
--- a/drivers/dma/shdma.c
+++ b/drivers/dma/shdma.c
@@ -649,7 +649,7 @@ static int __init sh_dmae_probe(struct platform_device *pdev)
 
 	/* get platform data */
 	if (!pdev->dev.platform_data)
-		goto shdev_err;
+		goto platform_err;
 
 	/* platform data */
 	memcpy(&shdev->pdata, pdev->dev.platform_data,
@@ -720,6 +720,7 @@ eirq_err:
 		free_irq(eirq[ecnt], shdev);
 
 rst_err:
+platform_err:
 	kfree(shdev);
 
 shdev_err:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/