linux-kernel - Re: [PATCH] mtd: fix mtd_blkdevs problem with caches on some architectures (2.6.31)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Nov 2009 22:18:36 +0300
From:	Ilya Loginov <isloginov@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Ingo Molnar <mingo@...e.hu>, David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, Peter Horton <phorton@...box.co.uk>,
	"Ed L. Cashin" <ecashin@...aid.com>,
	Jens Axboe <jens.axboe@...cle.com>
Subject: Re: [PATCH] mtd: fix mtd_blkdevs problem with caches on some
 architectures (2.6.31)

On Sun, 22 Nov 2009 10:48:16 -0800
Andrew Morton <akpm@...ux-foundation.org> wrote:

> I don't think the non-stub versions of these should be inlined.  They
> will generate quite a lot of code and they're pretty heavyweight.
> Better to implement them in block/ somewhere, and EXPORT_SYMBOL().

I tried this way from the beginning, and to avoid redefinitions I enclose
everything in #if #endif in *.c files. I think it is not very good.
So there are two possibilities.

1. To keep it like it is now and in this way there will be quite a lot of code.
But in previous letters I gave statistics on the flush_dcache_page call in a
kernel. And our case is particular. There will not be generated a lot of code.
Or just take away inline.

2. Or it is better to carry over normal realization to *.c file and enclose
everything by one more #if #endif.

What do you consier to be better?

-- 
Ilya Loginov <isloginov@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/