linux-kernel - Re: [PATCH] vhost: Fix warnings and bad type handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091122093630.GA13160@redhat.com>
Date:	Sun, 22 Nov 2009 11:36:32 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vhost: Fix warnings and bad type handling

On Tue, Nov 17, 2009 at 03:42:15PM +0000, Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@...ux.intel.com>

Thanks!
Acked-by: Michael S. Tsirkin <mst@...hat.com>

> ---
> 
>  drivers/vhost/vhost.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index 97233d5..46b20f7 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -334,7 +334,10 @@ static long vhost_set_vring(struct vhost_dev *d, int ioctl, void __user *argp)
>  			r = -EINVAL;
>  			break;
>  		}
> -		r = init_used(vq, (struct vring_used __user *)a.used_user_addr);
> +		/* For 32bit we will ignore the top 32bits of the user
> +		   data */

I am not sure this comment is helpful here: we actually verify that the
top 32 bits are set to 0, a couple of lines above this:

                if ((u64)(unsigned long)a.desc_user_addr != a.desc_user_addr ||
                    (u64)(unsigned long)a.used_user_addr != a.used_user_addr ||
                    (u64)(unsigned long)a.avail_user_addr != a.avail_user_addr) {
                        r = -EFAULT;
                        break;
                }


> +		r = init_used(vq, (struct vring_used __user *)(unsigned long)
> +						a.used_user_addr);
>  		if (r)
>  			break;
>  		vq->log_used = !!(a.flags & (0x1 << VHOST_VRING_F_LOG));
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/