[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1258973758.3629.64.camel@odin>
Date: Mon, 23 Nov 2009 10:55:58 +0000
From: Liam Girdwood <lrg@...mlogic.co.uk>
To: Julia Lawall <julia@...u.dk>
Cc: Mark Brown <broonie@...nsource.wolfsonmicro.com>,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drivers/regulator: use PTR_ERR to get error code
On Sat, 2009-11-21 at 22:18 +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
>
> IS_ERR returns only 1 or 0. The callsite of setup_regulators expects a
> negative integer in an error case. Thus, PTR_ERR has to be used to extract
> it.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression E,E1;
> @@
>
> *E = IS_ERR(...)
> ... when != E = E1
> *return E;
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@...u.dk>
>
Applied.
Thanks
Liam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists