linux-kernel - Re: [bisected] pty performance problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091123114845.GC25575@elte.hu>
Date:	Mon, 23 Nov 2009 12:48:45 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Mike Galbraith <efault@....de>, Robert Swan <swan.r.l@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [bisected] pty performance problem


* Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> > diff --git a/drivers/char/tty_buffer.c b/drivers/char/tty_buffer.c
> > index 66fa4e1..92a0864 100644
> > --- a/drivers/char/tty_buffer.c
> > +++ b/drivers/char/tty_buffer.c
> > @@ -495,7 +495,7 @@ void tty_flip_buffer_push(struct tty_struct *tty)
> >  	if (tty->low_latency)
> >  		flush_to_ldisc(&tty->buf.work.work);
> >  	else
> > -		schedule_delayed_work(&tty->buf.work, 1);
> > +		schedule_delayed_work(&tty->buf.work, 0);
> >  }
> >  EXPORT_SYMBOL(tty_flip_buffer_push);
> 
> Another possibility is to do
> 
> 	if (tty->low_latency)
> 		schedule_delayed_work(&tty->buf.work, 0);
> 	else
> 		schedule_delayed_work(&tty->buf.work, 1);

Flaggery for low latency is kind of lame though - especially if it 
defaults to off in most drivers as you say.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/