linux-kernel - Re: [PATCH]crypto: Add ghash algorithm test before provide to users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091123122357.GE6424@gondor.apana.org.au>
Date:	Mon, 23 Nov 2009 20:23:57 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	"Youquan,Song" <youquan.song@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, ying.huang@...el.com,
	kent.liu@...el.com, youquan.song@...el.com
Subject: Re: [PATCH]crypto: Add ghash algorithm test before provide to users

On Wed, Nov 18, 2009 at 07:42:46PM -0500, Youquan,Song wrote:
> Add ghash algorithm test before provide it to users
> 
> Signed-off-by: Youquan, Song <youquan.song@...el.com>

Patch applied.

> diff --git a/crypto/testmgr.h b/crypto/testmgr.h
> index 9963b18..fea00cd 100644
> --- a/crypto/testmgr.h
> +++ b/crypto/testmgr.h
> @@ -1003,6 +1003,23 @@ static struct hash_testvec tgr128_tv_template[] = {
>  	},
>  };
>  
> +#define GHASH_TEST_VECTORS 1
> +
> +static struct hash_testvec ghash_tv_template[] =
> +{
> +	{
> +
> +		.key	= "\xdf\xa6\xbf\x4d\xed\x81\xdb\x03\xff\xca\xff\x95\xf8\x30\xf0\x61",
> +		.ksize	= 16,
> +		.plaintext = "\x95\x2b\x2a\x56\xa5\x60\x04a\xc0\xb3\x2b\x66\x56\xa0\x5b\x40\xb6",
> +		.psize	= 16,
> +		.digest	= "\xda\x53\xeb\x0a\xd2\xc5\x5b\xb6"
> +			  "\x4f\xc4\x80\x2c\xc3\xfe\xda\x60",
> +	},
> +};
> +
> +/*
> + * HMAC-MD5 test vectors from RFC2202
>  /*
>   * HMAC-MD5 test vectors from RFC2202
>   * (These need to be fixed to not use strlen).

This adds two bogus lines.  I've removed them for you but please
be more careful next time.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/