[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091124101403.GA25364@pengutronix.de>
Date: Tue, 24 Nov 2009 11:14:03 +0100
From: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...e.hu>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Luming Yu <luming.yu@...il.com>
Subject: Re: [PATCH 1/2] hrtimer: correct a few numbers in comments and
printk outputs
Hello Andrew,
On Mon, Nov 23, 2009 at 03:25:16PM -0800, Andrew Morton wrote:
> On Fri, 20 Nov 2009 20:23:39 +0100
> Uwe Kleine-K__nig <u.kleine-koenig@...gutronix.de> wrote:
>
> > @@ -52,7 +52,7 @@ int tick_dev_program_event(struct clock_event_device *dev, ktime_t expires,
> > printk(KERN_WARNING
> > "CE: %s increasing min_delta_ns to %lu nsec\n",
> > dev->name ? dev->name : "?",
> > - dev->min_delta_ns << 1);
> > + dev->min_delta_ns);
> >
> > i = 0;
> > }
>
> This one's already in linux-next:
>
> @@ -50,9 +50,9 @@ int tick_dev_program_event(struct clock_
> dev->min_delta_ns += dev->min_delta_ns >> 1;
>
> printk(KERN_WARNING
> - "CE: %s increasing min_delta_ns to %lu nsec\n",
> + "CE: %s increasing min_delta_ns to %llu nsec\n",
> dev->name ? dev->name : "?",
> - dev->min_delta_ns << 1);
> + (unsigned long long) dev->min_delta_ns << 1);
'<< 1' is wrong here, too.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists