linux-kernel - [PATCH 3/5] slab.c: remove branch hint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Nov 2009 11:55:36 +0100
From:	Tim Blechmann <tim@...ngt.org>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH 3/5] slab.c: remove branch hint

branch profiling on my nehalem machine showed 99% incorrect branch hints:

   28459  7678524  99 __cache_alloc_node             slab.c
  3551

Signed-off-by: Tim Blechmann <tim@...ngt.org>
---
 mm/slab.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index f70b326..4125fcd 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3548,7 +3548,7 @@ __cache_alloc_node(struct kmem_cache *cachep,
gfp_t flags, int nodeid,
 	slab_irq_save(save_flags, this_cpu);
  	this_node = cpu_to_node(this_cpu);
-	if (unlikely(nodeid == -1))
+	if (nodeid == -1)
 		nodeid = this_node;
  	if (unlikely(!cachep->nodelists[nodeid])) {
-- 
1.6.4.2



Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)