linux-kernel - [PATCH 5/5] workqueue.c: remove branch hint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 24 Nov 2009 11:55:52 +0100
From:	Tim Blechmann <tim@...ngt.org>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH 5/5] workqueue.c: remove branch hint

branch hint profiling of my nehalem machine, showed 96% incorrect branch
hints:

131609  3840434  96 queue_delayed_work_on          workqueue.c          258

Signed-off-by: Tim Blechmann <tim@...ngt.org>
---
 kernel/workqueue.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 0a98bef..6985ab0 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -255,7 +255,7 @@ int queue_delayed_work_on(int cpu, struct
workqueue_struct *wq,
 		timer->data = (unsigned long)dwork;
 		timer->function = delayed_work_timer_fn;
 -		if (unlikely(cpu >= 0))
+		if (cpu >= 0)
 			add_timer_on(timer, cpu);
 		else
 			add_timer(timer);
-- 
1.6.4.2



Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)