linux-kernel - Re: [PATCH][mmc/host]:Blackfin SD Host Controller Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8bd0f97a0911240835j1d360b39tda688e551052c5c7@mail.gmail.com>
Date:	Tue, 24 Nov 2009 11:35:56 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	cliffcai.sh@...il.com
Cc:	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	cliff.cai@...log.com
Subject: Re: [PATCH][mmc/host]:Blackfin SD Host Controller Driver

On Tue, Nov 24, 2009 at 10:39,  <cliffcai.sh@...il.com> wrote:
> From: Cliff Cai <cliffcai.sh@...il.com>
>
> Signed-off-by: Cliff Cai <cliffcai.sh@...il.com>

you dropped some people's s-o-b tags

> +out4:
> +       free_irq(host->irq, host);

you didnt address the feedback given last time here:
    You need a mmc_remove_host() here.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/