linux-kernel - Re: [PATCH 0/5] branch hint tweaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Nov 2009 12:50:48 -0500
From:	Brian Gerst <brgerst@...il.com>
To:	Tim Blechmann <tim@...ngt.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] branch hint tweaks

On Tue, Nov 24, 2009 at 5:54 AM, Tim Blechmann <tim@...ngt.org> wrote:
> hi all,
>
> doing some branch hint profiling of 2.6.31 on my nehalem machine showed
> a few
> incorrect branch hints.
> these patches remove or change the branch hints
>
> Tim Blechmann (5):
>  process_64: remove branch hint
>  sched.c: change branch hint
>  slab.c: remove branch hint
>  sched_fair.c: remove branch hint
>  workqueue.c: remove branch hint
>
>  arch/x86/kernel/process_64.c |    4 ++--
>  kernel/sched.c               |    4 ++--
>  kernel/sched_fair.c          |    2 +-
>  kernel/workqueue.c           |    2 +-
>  mm/slab.c                    |    2 +-
>  5 files changed, 7 insertions(+), 7 deletions(-)

Did you run profiling tests again after making these changes to see if
they had any effect?  likely() and unlikely() are only hints.  GCC
doesn't have to follow them, or it could be broken in recent GCC
versions.

I'm not sure what version of GCC added this, but I wonder if this
option will fix the problem:

-fno-guess-branch-probability
    Do not guess branch probabilities using heuristics.

    GCC will use heuristics to guess branch probabilities if they are
not provided by profiling feedback (-fprofile-arcs). These heuristics
are based on the control flow graph. If some branch probabilities are
specified by `__builtin_expect', then the heuristics will be used to
guess branch probabilities for the rest of the control flow graph,
taking the `__builtin_expect' info into account. The interactions
between the heuristics and `__builtin_expect' can be complex, and in
some cases, it may be useful to disable the heuristics so that the
effects of `__builtin_expect' are easier to understand.

    The default is -fguess-branch-probability at levels -O, -O2, -O3, -Os.

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/