linux-kernel - Re: MODULE_DEVICE_TABLE(isapnp, ...) does nothing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200911242223.33206.linux@rainbow-software.org>
Date:	Tue, 24 Nov 2009 22:23:30 +0100
From:	Ondrej Zary <linux@...nbow-software.org>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Takashi Iwai <tiwai@...e.de>,
	Rusty Russell <rusty@...tcorp.com.au>,
	linux-kernel@...r.kernel.org,
	Jon Masters <jonathan@...masters.org>,
	Jaroslav Kysela <perex@...ex.cz>, Greg KH <gregkh@...e.de>
Subject: Re: MODULE_DEVICE_TABLE(isapnp, ...) does nothing

On Tuesday 24 November 2009 09:57:28 Kay Sievers wrote:
> On Tue, Nov 24, 2009 at 08:29, Ondrej Zary <linux@...nbow-software.org> 
wrote:
> > On Monday 23 November 2009, Kay Sievers wrote:
> >> On Mon, Nov 23, 2009 at 09:40, Takashi Iwai <tiwai@...e.de> wrote:
> >> > At Mon, 23 Nov 2009 13:59:53 +1030,
> >> >
> >> > Rusty Russell wrote:
> >> >> On Mon, 23 Nov 2009 07:31:57 am Ondrej Zary wrote:
> >> >> > The problem is that
> >> >> > scripts/mod/file2alias.c simply ignores isapnp.
> >> >>
> >> >> AFAICT it always has, and noone has complained until now.  Perhaps
> >> >> something was still reading /lib/modules/`uname
> >> >> -r`/modules.isapnpmap?
> >> >
> >> > I don't think modules.isapnpmap is needed again.
> >> > The question came from the fact that the isapnp device wasn't loaded
> >> > automatically.
> >>
> >> All the map files are not uses for anything these days. Ideally,
> >> depmod should just stop creating these dead files.
> >>
> >> > But, I thought Kay already added isapnp support sometime ago, but it
> >> > didn't seem to get in...  Kay?
> >>
> >> No, we don't even have proper modaliases for the pnp bus
> >> (/sys/bus/pnp) and the alias string for pnp in the modules have a
> >> broken and unfixable format. PNP autoloading is all handled by the
> >> acpi modaliases these days. This is the first time in years I hear
> >> anybody asking for hotplug setups of plain old pnp devices. :)
> >
> > Added these two lines to modules.alias (and deleted modules.alias.bin):
> > alias acpi*:RTL8019:* ne
> > alias pnp:dRTL8019* ne
> >
> > and it works. This works too:
> > alias acpi*:PNP80d6:* ne
> > alias pnp:dPNP80d6* ne
>
> Oh, your box has acpi mapped pnp aliases for this device? You can see
> your ID string somewhere in this list?
>   grep . /sys/bus/acpi/devices/*/modalias
>
> If not, is it in the pnp bus list?
>   grep . /sys/bus/pnp/devices/*/id

It's listen in the pnp bus only:

$ grep -i 80d6 /sys/bus/acpi/devices/*/modalias
$ grep -i 80d6 /sys/bus/pnp/devices/*/id
/sys/bus/pnp/devices/01:01.00/id:PNP80d6
$ cat /sys/bus/pnp/devices/01\:01.00/id
RTL8019
PNP80d6

So the acpi alias was useless (I just copied another entry). This alone works:
alias pnp:dPNP80d6* ne

-- 
Ondrej Zary
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/