linux-kernel - Re: [PATCH 02/38] move atp870u

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1259098696.4549.643.camel@mulgrave.site>
Date:	Tue, 24 Nov 2009 15:38:16 -0600
From:	James Bottomley <James.Bottomley@...e.de>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Yang Hongyang <yanghy@...fujitsu.com>,
	Alan Cox <alan@...ux.intel.com>, linux-scsi@...r.kernel.org,
	Alan Cox <alan@...hat.com>
Subject: Re: [PATCH 02/38] move atp870u_remove to .devexit.text

On Tue, 2009-11-24 at 22:06 +0100, Uwe Kleine-König wrote:
> The function atp870u_remove is used only wrapped by __devexit_p so define
> it using __devexit.

But there's really no point to this.  HOTPLUG is always defined on SCSI
systems that have these drivers, which means that _devinit/exit are
nops.  That makes the change purely cosmetic and not worth churning two
dozen drivers for.

Even for the EMBEDDED cases that should care about this, the maintainers
have indicated that the memory savings simply aren't worth the hassle of
tracking the sectional updates.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/