linux-kernel - Re: [PATCH] x86/pci: remove early PCI pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091124135202.2637c383@jbarnes-piketon>
Date:	Tue, 24 Nov 2009 13:52:02 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Alex Chiang <achiang@...com>
Cc:	linux-pci <linux-pci@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/pci: remove early PCI pr_debug statements

On Mon, 16 Nov 2009 14:21:13 -0700
Alex Chiang <achiang@...com> wrote:

> commit db635adc turned -DDEBUG for x86/pci on when CONFIG_PCI_DEBUG
> is set. In general, I agree with that change.
> 
> However, it exposes a bunch of very low level PCI debugging in the
> early x86 path, such as:
> 
> 	0 reading 2 from a: ffff
> 	1 reading 2 from a: ffff
> 	2 reading 2 from a: ffff
> 	3 reading 2 from a: 300
> 	3 reading 2 from 0: 1002
> 	3 reading 2 from 2: 515e
> 
> These statements add a lot of noise to the boot and aren't likely to
> be necessary even when handling random upstream bug reports.
> 
> [In contrast, statements such as these:
> 
> 	pci 0000:02:04.0: found [14e4:164a] class 000200 header type
> 00 pci 0000:02:04.0: reg 10: [mem 0xf8000000-0xf9ffffff 64bit]
> 	pci 0000:02:04.0: reg 30: [mem 0x00000000-0x0001ffff pref]
> 
> are indeed useful when remote debugging users' machines]
> 
> Remove the noisy printks and save electrons everywhere.

Applied, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/