linux-kernel - Re: [PATCH XFS] Fix error return for fallocate() on XFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B0C6B5A.6080702@sandeen.net>
Date:	Tue, 24 Nov 2009 17:25:14 -0600
From:	Eric Sandeen <sandeen@...deen.net>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
CC:	xfs-masters@....sgi.com, linux-kernel@...r.kernel.org,
	xfs@....sgi.com
Subject: Re: [PATCH XFS] Fix error return for fallocate() on XFS

Jason Gunthorpe wrote:
> Noticed that through glibc fallocate would return 28 rather than -1
> and errno = 28 for ENOSPC. The xfs routines uses XFS_ERROR format
> positive return error codes while the syscalls use negative return codes.
> Fixup the two cases in xfs_vn_fallocate syscall to convert to negative.

grumblegrumble xfs error signs grumble...

> Signed-off-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>

Thanks,

Reviewed-by: Eric Sandeen <sandeen@...deen.net>

> ---
>  fs/xfs/linux-2.6/xfs_iops.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c
> index cd42ef7..1f3b4b8 100644
> --- a/fs/xfs/linux-2.6/xfs_iops.c
> +++ b/fs/xfs/linux-2.6/xfs_iops.c
> @@ -573,8 +573,8 @@ xfs_vn_fallocate(
>  	bf.l_len = len;
>  
>  	xfs_ilock(ip, XFS_IOLOCK_EXCL);
> -	error = xfs_change_file_space(ip, XFS_IOC_RESVSP, &bf,
> -				      0, XFS_ATTR_NOLOCK);
> +	error = -xfs_change_file_space(ip, XFS_IOC_RESVSP, &bf,
> +				       0, XFS_ATTR_NOLOCK);
>  	if (!error && !(mode & FALLOC_FL_KEEP_SIZE) &&
>  	    offset + len > i_size_read(inode))
>  		new_size = offset + len;
> @@ -585,7 +585,7 @@ xfs_vn_fallocate(
>  
>  		iattr.ia_valid = ATTR_SIZE;
>  		iattr.ia_size = new_size;
> -		error = xfs_setattr(ip, &iattr, XFS_ATTR_NOLOCK);
> +		error = -xfs_setattr(ip, &iattr, XFS_ATTR_NOLOCK);
>  	}
>  
>  	xfs_iunlock(ip, XFS_IOLOCK_EXCL);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/