linux-kernel - Re: [rfc] "fair" rw spinlocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091125085609.GF17484@wotan.suse.de>
Date:	Wed, 25 Nov 2009 09:56:09 +0100
From:	Nick Piggin <npiggin@...e.de>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org
Subject: Re: [rfc] "fair" rw spinlocks

On Wed, Nov 25, 2009 at 09:49:23AM +0100, Andi Kleen wrote:
> David Miller <davem@...emloft.net> writes:
> >
> > I think nobody would notice if you changed tasklist_lock into
> > a spinlock_t, and this would solve the DoS because at least on
> > x86 you'd end up with the ticket spinlocks.
> 
> iirc tasklist_lock was one of them who could be potentially nested.
> 
> So just turning it into a spinlock might deadlock.

It can be nested I think due to interrupt context. But if the read
side disables interrupts too, then I think it should be OK (though
I haven't audited this closely).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/