linux-kernel - Re: [PATCH 3/5] slab.c: remove branch hint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B0D09F5.6020305@cs.helsinki.fi>
Date:	Wed, 25 Nov 2009 12:41:57 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Tim Blechmann <tim@...ngt.org>, linux-kernel@...r.kernel.org,
	Christoph Lameter <cl@...ux-foundation.org>,
	Nick Piggin <npiggin@...e.de>,
	David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH 3/5] slab.c: remove branch hint

Ingo Molnar kirjoitti:
>> That sounds odd to me. Can you see where the incorrectly predicted
>> calls are coming from? Calling kmem_cache_alloc_node() with node set
>> to -1 most of the time could be a real bug somewhere.
> 
> I think it could occur in too limited tests - the branch prediction 
> looks 'wrong' in certain tests - while it's OK in general.
> 
> Is there some easy to run workload you consider more or less 
> representative of typical SLAB patterns?

I can think of three main classes: VFS, SCSI, or network intensive 
applications and benchmarks tend to bring out the worst in SLAB. There 
are probably some interesting NUMA related things that I'm not really 
aware of.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/