[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <4b0d2fe4.0ab6660a.6437.3cfc@mx.google.com>
Date: Wed, 25 Nov 2009 15:23:41 +0200
From: Shmulik Ladkani <shmulik.ladkani@...il.com>
To: mingo@...e.hu, peterz@...radead.org, linux-kernel@...r.kernel.org
Subject: [PATCH] sched.c: call debug_show_all_locks when dumping all tasks
show_state_filter() failed to call debug_show_all_locks() when specified to
dump all tasks.
Fix: call debug_show_all_locks() when !state_filter (since !state_filter
means "all tasks").
Signed-off-by: Shmulik Ladkani <shmulik.ladkani@...il.com>
---
In commit 39bc89fd4019b164002adaacef92c4140e37955a the interface of
show_state_filter() was changed: zero valued 'state_filter' specifies "dump all
tasks" (instead of -1).
However, the condition for calling debug_show_all_locks() ("show locks if all
tasks are dumped") was not updated accordingly.
diff --git a/kernel/sched.c b/kernel/sched.c
index 3c11ae0..6e2b936 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -6935,7 +6935,7 @@ void show_state_filter(unsigned long state_filter)
/*
* Only show locks if all tasks are dumped:
*/
- if (state_filter == -1)
+ if (!state_filter)
debug_show_all_locks();
}
--
Shmulik Ladkani
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists