linux-kernel - [PATCH 1/3]fs/inode: iunique() Optimize Performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <200911252209432039291@gmail.com>
Date:	Wed, 25 Nov 2009 22:09:45 +0800
From:	"Liuweni" <qingshenlwy@...il.com>
To:	"linux-kernel" <linux-kernel@...r.kernel.org>
Cc:	"strongzgy" <strongzgy@...il.com>, "xgr178" <xgr178@....com>,
	"Liu Hui" <onlyflyer@...il.com>, "viro" <viro@...iv.linux.org.uk>,
	"akpm" <akpm@...ux-foundation.org>, "jack" <jack@...e.cz>,
	"npiggin" <npiggin@...e.de>,
	"linux-fsdevel" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>
Subject: [PATCH 1/3]fs/inode: iunique() Optimize Performance

---
move the if condition out the while{}.
While the function executing, the if 
condition won't check again and again.
And this code won't change the function
of iunique().

---
Signed-off-by: Liuwenyi<qingshenlwy@...il.com>
Cc: Alexander Viro <viro@...iv.linux.org.uk>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Jan Kara <jack@...e.cz>
Cc: Nick Piggin <npiggin@...e.de>
Cc: linux-fsdevel@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
---
diff --git a/fs/inode.c b/fs/inode.c
index 4d8e3be..8ff1e99 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -838,9 +838,10 @@ ino_t iunique(struct super_block *sb, ino_t max_reserved)
 	ino_t res;
 
 	spin_lock(&inode_lock);
+
+	if (counter <= max_reserved)
+		counter = max_reserved + 1;
 	do {
-		if (counter <= max_reserved)
-			counter = max_reserved + 1;
 		res = counter++;
 		head = inode_hashtable + hash(sb, res);
 		inode = find_inode_fast(sb, head, res);

 				
--------------
Best Regards,
Liuweni
2009-11-25

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/