linux-kernel - Re: [PATCH 2/3]fs/inode: iunique() Optimize Performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091125141727.GI9482@parisc-linux.org>
Date:	Wed, 25 Nov 2009 07:17:28 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Liuweni <qingshenlwy@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	viro <viro@...iv.linux.org.uk>, akpm <akpm@...ux-foundation.org>,
	jack <jack@...e.cz>, npiggin <npiggin@...e.de>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	strongzgy <strongzgy@...il.com>, xgr178 <xgr178@....com>,
	Liu Hui <onlyflyer@...il.com>
Subject: Re: [PATCH 2/3]fs/inode: iunique() Optimize Performance

On Wed, Nov 25, 2009 at 10:12:19PM +0800, Liuweni wrote:
> @@ -605,8 +605,8 @@ static unsigned long hash(struct super_block *sb, unsigned long hashval)
>  {
>  	unsigned long tmp;
>  
> -	tmp = (hashval * (unsigned long)sb) ^ (GOLDEN_RATIO_PRIME + hashval) /
> -			L1_CACHE_BYTES;
> +	tmp = (hashval * (unsigned long)sb) ^ (GOLDEN_RATIO_PRIME + hashval) >>
> +			L1_CACHE_SHIFT;
>  	tmp = tmp ^ ((tmp ^ GOLDEN_RATIO_PRIME) >> I_HASHBITS);
>  	return tmp & I_HASHMASK;
>  }

Have you compared the compiler output before/after your change?  I'd be
amazed if GCC isn't able to optimise division-by-a-constant-power-of-two
into shift-by-constant.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/