linux-kernel - Re: [PATCH] cfq-iosched: cleanup unreachable code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091126084223.GN8742@kernel.dk>
Date:	Thu, 26 Nov 2009 09:42:24 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Corrado Zoccolo <czoccolo@...il.com>
Cc:	Linux-Kernel <linux-kernel@...r.kernel.org>,
	Jeff Moyer <jmoyer@...hat.com>, Vivek Goyal <vgoyal@...hat.com>
Subject: Re: [PATCH] cfq-iosched: cleanup unreachable code

On Tue, Nov 24 2009, Corrado Zoccolo wrote:
> cfq_should_idle returns false for no-idle queues that are not the last,
> so the control flow will never reach the removed code in a state that
> satisfies the if condition.
> The unreachable code was added to emulate previous cfq behaviour for
> non-NCQ rotational devices. My tests show that even without it, the
> performances and fairness are comparable with previous cfq, thanks to
> the fact that all seeky queues are grouped together, and that we idle at
> the end of the tree.

Applied, thanks.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/